-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require manual confirmation to purge database with purge-db
#6154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macladson
added
ready-for-review
The code is ready for review
UX-and-logs
backwards-incompat
Backwards-incompatible API change
work-in-progress
PR is a work-in-progress
and removed
ready-for-review
The code is ready for review
labels
Jul 23, 2024
macladson
added
ready-for-review
The code is ready for review
and removed
work-in-progress
PR is a work-in-progress
labels
Jul 28, 2024
macladson
commented
Jul 28, 2024
michaelsproul
added
waiting-on-author
The reviewer has suggested changes and awaits thier implementation.
and removed
ready-for-review
The code is ready for review
labels
Aug 19, 2024
macladson
added
ready-for-review
The code is ready for review
and removed
waiting-on-author
The reviewer has suggested changes and awaits thier implementation.
labels
Aug 19, 2024
michaelsproul
added
ready-for-merge
This PR is ready to merge.
and removed
ready-for-review
The code is ready for review
labels
Aug 20, 2024
michaelsproul
approved these changes
Aug 20, 2024
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 32f2e05 |
This was referenced Aug 20, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backwards-incompat
Backwards-incompatible API change
ready-for-merge
This PR is ready to merge.
UX-and-logs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#5028
Proposed Changes
The
purge-db
flag now requires manual confirmation in order to purge the database.A new flag called
purge-db-force
has been added for those who still wish to purge with no intervention.Additional Info
This is a pretty spicy breaking change as I suspect
--purge-db
is widely used.See the alternative (although outdated) PR here which adds a
purge-db-safe
flag, which means the safety would effectively become opt-in. In my opinion this is unnatural, although more convenient as it doesn't require a breaking change.